Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor http service with authentication middleware. #236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor http service with authentication middleware. #236

wants to merge 1 commit into from

Conversation

suzp1984
Copy link
Contributor

@suzp1984 suzp1984 commented Nov 26, 2024 •
edited
Loading

What's the problem of http api authentication?

There are a lot of repeated codes in the http api hander func.

oryx/platform/transcript.go

Lines 66 to 78 in 9b475d9

var token string
if err := ParseBody(ctx, r.Body, &struct {
Token *string `json:"token"`
}{
Token: &token,
}); err != nil {
return errors.Wrapf(err, "parse body")
}
apiSecret := envApiSecret()
if err := Authenticate(ctx, apiSecret, token, r.Header); err != nil {
return errors.Wrapf(err, "authenticate")
}

Solution

refactor those token authentication codes to one place.
There are 2 kinds of token verification.

  1. Token in http post body.
    middlewareAuthTokenInBody
  2. Token in url query.
    middlewareAuthTokenInURL
  3. ai-talk.go is an exception, the token authentication depends room token, so keep ai-talk.go.

@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Nov 26, 2024
@suzp1984 suzp1984 force-pushed the refactor/http-handler-middleware branch from dacc034 to c098941 Compare November 26, 2024 12:44
@suzp1984 suzp1984 force-pushed the refactor/http-handler-middleware branch from c098941 to a70326c Compare November 26, 2024 12:52
@suzp1984 suzp1984 marked this pull request as ready for review November 26, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suzp1984 @winlinvip